Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 version added and removed 10.1 #1063

Merged
merged 8 commits into from
Aug 13, 2024

Conversation

kedarkhaire
Copy link
Collaborator

@kedarkhaire kedarkhaire commented Jun 18, 2024

Fixes #1060

@kedarkhaire
Copy link
Collaborator Author

kedarkhaire commented Jun 19, 2024

Issues with 10.3 compatibility throws error for deprecated on Drupal Check

  1. Error: Call to deprecated method getName() of interface Drupal\Core\Extension\ModuleHandlerInterface:
    in drupal:1***.3.*** and is removed from drupal:12...
    Use \Drupal::service('extension.list.module')->getName($module) instead.
  2. Error: Class Drupal\apigee_edge\Element\ApigeeEntityListElement extends deprecated class Drupal\Core\Render\Element\RenderElement:
    in drupal:1***.3.*** and is removed from drupal:12... Use
    \Drupal\Core\Render\Element\RenderElementBase instead.
  3. Error: Call to method __construct() of deprecated class Drupal\Core\Render\Element\RenderElement:
    in drupal:1***.3.*** and is removed from drupal:12... Use
    \Drupal\Core\Render\Element\RenderElementBase instead.
  4. Error: Class Drupal\apigee_edge\Element\ApigeeSecret extends deprecated class Drupal\Core\Render\Element\RenderElement:
    in drupal:1***.3.*** and is removed from drupal:12... Use
    \Drupal\Core\Render\Element\RenderElementBase instead.
  5. Error: Class Drupal\apigee_edge\Element\AppCredentialElement extends deprecated class Drupal\Core\Render\Element\RenderElement:
    in drupal:1***.3.*** and is removed from drupal:12... Use
    \Drupal\Core\Render\Element\RenderElementBase instead.
  6. Error: Class Drupal\apigee_edge\Element\AppCredentialProductListElement extends deprecated class Drupal\Core\Render\Element\RenderElement:
    in drupal:1***.3.*** and is removed from drupal:12... Use
    \Drupal\Core\Render\Element\RenderElementBase instead.
  7. Error: Class Drupal\apigee_edge\Element\StatusPropertyElement extends deprecated class Drupal\Core\Render\Element\RenderElement:
    in drupal:1***.3.*** and is removed from drupal:12... Use
    \Drupal\Core\Render\Element\RenderElementBase instead.
  8. Error: Call to deprecated method renderPlain() of interface Drupal\Core\Render\RendererInterface:
    in drupal:1***.3.*** and is removed from drupal:12... Use
    \Drupal\Core\Render\RendererInterface::renderInIsolation() instead.
  9. Error: Fetching deprecated class constant EXISTS_REPLACE of interface Drupal\Core\File\FileSystemInterface:
    in drupal:1***.3.*** and is removed from drupal:12... Use
    \Drupal\Core\File\FileExists::Replace instead.
  10. Error: Fetching deprecated class constant EXISTS_REPLACE of interface Drupal\Core\File\FileSystemInterface:
    in drupal:1***.3.*** and is removed from drupal:12... Use
    \Drupal\Core\File\FileExists::Replace instead.
  11. Error: Fetching deprecated class constant EXISTS_REPLACE of interface Drupal\Core\File\FileSystemInterface:
    in drupal:1***.3.*** and is removed from drupal:12... Use
    \Drupal\Core\File\FileExists::Replace instead.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.37%. Comparing base (e5569e8) to head (3879a05).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                3.x    #1063   +/-   ##
=========================================
  Coverage     44.37%   44.37%           
  Complexity     3041     3041           
=========================================
  Files           342      342           
  Lines         11111    11111           
=========================================
  Hits           4931     4931           
  Misses         6180     6180           

@kedarkhaire kedarkhaire changed the title Edge changes of PHP & Drupal version support updates Support added PHP version update Jun 24, 2024
@kedarkhaire kedarkhaire changed the title Support added PHP version update PHP 8.3 version added Jun 25, 2024
@shishir-intelli shishir-intelli changed the title PHP 8.3 version added PHP 8.3 version added and removed 10.1 Aug 13, 2024
Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 740605c into apigee:3.x Aug 13, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of PHP8.3 for Apigee Edge module
2 participants